fix: enable default features on WriteBuilder datafusion context
#3850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhi Agarwal <[email protected]>
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
abhi-airspace-intelligence
changed the title
WriteBuilder datafusion contextWriteBuilder datafusion context
rtyler
approved these changes
Oct 16, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3850 +/- ##
==========================================
- Coverage 73.77% 73.75% -0.02%
==========================================
Files 151 151
Lines 39139 39117 -22
Branches 39139 39117 -22
==========================================
- Hits 28873 28850 -23
- Misses 8995 8997 +2
+ Partials 1271 1270 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@abhi-airspace-intelligence - This might be also addressed in #3860 where we centralise creating the sessions a bit more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ran into this edge case where if writing to a table that has a generated column defined by a SQL function (say, as a partition column,
to_char(timestamp), the write builder will fail since a default SessionState does not have UDFs unlessnew_with_default_featuresis specified.Related Issue(s)
Regression from #3816
Documentation
Left as draft since I want to write a regression test to assert this doesn't happen again